Skip to content

fix(client): keep artifact cards inside agent replies#4

Merged
auspham merged 1 commit into
mainfrom
austinpham/inline-agent-response-card
Jul 14, 2026
Merged

fix(client): keep artifact cards inside agent replies#4
auspham merged 1 commit into
mainfrom
austinpham/inline-agent-response-card

Conversation

@auspham

@auspham auspham commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

Scope comment rail card styles to direct rail children so an artifact element using the generic .card class remains inline inside the cloned agent answer instead of becoming a second fixed rail card.

Extend the browser regression fixture to cover rich answer content containing .card and assert that the outer comment card remains fixed while the nested artifact card remains in normal flow.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor or tooling
  • Other:

How was this tested?

The updated browser regression failed before the selector fix with the nested artifact card computed as position: fixed, then passed with it computed as position: static. The exact reported live review card was also checked against the locally synced client.

  • python -m pytest tests/python
  • ruff check skills/htmlit tests/python
  • npm test (browser client)

Checklist

  • I added or updated tests for this change (a bug fix has a test that fails before the fix).
  • I did not add any runtime dependency to the skill (standard library only).
  • I did not commit vendored assets (Mermaid, highlight.js, Idiomorph).
  • Commits follow Conventional Commits and are signed off (git commit -s).

Copilot-Session: 7a66568e-3c1d-4cc8-8f79-acfc0b6c3f91
Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>
@auspham auspham merged commit f00c320 into main Jul 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant