fix(client): keep artifact cards inside agent replies#4
Merged
Conversation
Copilot-Session: 7a66568e-3c1d-4cc8-8f79-acfc0b6c3f91 Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope comment rail card styles to direct rail children so an artifact element using the generic
.cardclass remains inline inside the cloned agent answer instead of becoming a second fixed rail card.Extend the browser regression fixture to cover rich answer content containing
.cardand assert that the outer comment card remains fixed while the nested artifact card remains in normal flow.Type of change
How was this tested?
The updated browser regression failed before the selector fix with the nested artifact card computed as
position: fixed, then passed with it computed asposition: static. The exact reported live review card was also checked against the locally synced client.python -m pytest tests/pythonruff check skills/htmlit tests/pythonnpm test(browser client)Checklist
git commit -s).