fix(client): skip structural whitespace in annotations#5
Merged
Conversation
Copilot-Session: 7a66568e-3c1d-4cc8-8f79-acfc0b6c3f91 Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent persistent text annotations from wrapping whitespace-only slices when a selection crosses nested elements. Those synthetic
<mark>nodes became real grid or flex children in artifact layouts, producing large empty elements beside the selected content.Add a browser regression that anchors a full card inside a CSS grid and verifies the selected text remains marked without adding whitespace marks or synthetic grid children.
Type of change
How was this tested?
The browser regression failed before the fix with five whitespace-only marks, then passed after
wrapRangeskipped whitespace-only text slices.python -m pytest tests/pythonruff check skills/htmlit tests/pythonnpm test(browser client)Checklist
git commit -s).