Fix game picker outside-tap dismissal on iOS - #79
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
# Conflicts: # ComputerSolitaire.xcodeproj/project.pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS, tapping outside the game picker panel often failed to dismiss it, even though the scrim is wired as the picker's cancel button. Two layered causes:
ignoresSafeArea()was applied to theColorinside the button's label, which paints edge to edge but leaves the button's hit region inset — taps in the top and bottom strips hit nothing. Moving the modifier onto the button itself makes the hit area truly full-screen..toolbar(.hidden, for: .bottomBar)is inert here because no NavigationStack hosts the bar, so the items are conditionally removed instead.With the bar gone while the picker is up, the panel also gains enough height that all nine games fit without the scrolling fallback on current iPhones.
macOS is unaffected: the toolbar change is iOS-gated and the scrim change is a no-op without safe-area insets.
Testing
testTapOutsideDismissesGamePicker(iOS) covers the bottom-strip tap — the previously dead zone — and asserts the toolbar leaves while the picker is open and returns after dismissal.