New setting in store provider denoting whether to use the internal cache

[tocr]

• new setting added into the store provider
• caching adjusted in the Internal store to reflect the useCache setting
• test cases added

[mgonto]

add a space after the if

[mgonto]

Thanks for the PR :).

Only comment is that since you've added useCache before the delimited, that means this is a breaking change :D which I don't want. Could you move it to after the delimeter.

If we were to do a breaking change, I'd prefer to change the parameters to be options so that order doesn't matter, but for next version :D.

Thanks!

[tocr]

Thanks for your comments. I made changes to preserve the API of the library.

[mgonto]

use angular.isDefined

[mgonto]

Actually, just set this.useCache = !!useCache. If undefined or null, it'll be false :).

[tocr]

Oh, not again cast-to-bool operator :)
Anyway, I don't think it would work. !! defaults null/undefined to false. I need to default it to true.

Or, I could revert the semantics and rename it to 'dontUseCache' Then the !! would work I think

[mgonto]

A few more comments, but it looks really good.

Thanks!

[mgonto]

Can you rebase with amster and we'll merge?

Thanks!

[tocr]

I made a merge from upstream. I am sorry for the delay.

[acorbel]

Hi,

Any update for this PR?

[pranshunz]

Whats the status of this PR?