This repository was archived by the owner on Sep 15, 2022. It is now read-only.
Make test working for angular 1.4.x and $cookies service#52
Merged
chenkie merged 4 commits intoauth0:masterfrom Mar 25, 2016
Merged
Make test working for angular 1.4.x and $cookies service#52chenkie merged 4 commits intoauth0:masterfrom
chenkie merged 4 commits intoauth0:masterfrom
Conversation
added 4 commits
January 6, 2016 10:18
* implementation of ngCookies has changed in angular 1.4 and therefore the unit tests were failing * mocked the cookieStore methods to make it working
Contributor
|
Hey, I haven't forgotten about this but just left town for a bit and the tests were giving me issues before I left. I'll come back to this as soon as I'm back :) |
|
Sooner this can get in and fixed the better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47