v4 release: Fixed package name, updated versions in readme#635
Merged
stevehobbsdev merged 1 commit intomasterfrom Feb 7, 2020
Merged
v4 release: Fixed package name, updated versions in readme#635stevehobbsdev merged 1 commit intomasterfrom
stevehobbsdev merged 1 commit intomasterfrom
Conversation
davidpatrick
approved these changes
Feb 7, 2020
avatsaev
reviewed
Feb 10, 2020
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "angular2-jwt", | |||
| "name": "@auth0/angular-jwt", | |||
Contributor
There was a problem hiding this comment.
Just to let you know, this package.json file doesn't concern the library itself, but the test host application, so we don't have to give it the same name as the lib, this might even cause problems while npm-linking the lib while testing locally, the lib's package.json file is in projects/angular-jwt/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This fixes up a couple of things in the readme and
package.jsonin preparation for a v4 release.Checklist