Introduce Interfaces to Final Classes#581
Merged
evansims merged 3 commits intoauth0:mainfrom Oct 27, 2021
jobcloud:feat/update-version-8-add-interfaces
Merged
Introduce Interfaces to Final Classes#581evansims merged 3 commits intoauth0:mainfrom jobcloud:feat/update-version-8-add-interfaces
evansims merged 3 commits intoauth0:mainfrom
jobcloud:feat/update-version-8-add-interfaces
Conversation
komando82
changed the title
Contributor
|
Hey @komando82, thanks for your hard work on this! This was the same approach I had been working on, but you beat me to the punch at getting this far. Let me give this a thorough look over and get back to you, but I like what I'm seeing. 👍 |
evansims
approved these changes
Oct 27, 2021
Contributor
evansims
left a comment
evansims
left a comment
There was a problem hiding this comment.
Hey @komando82 👋 Thanks for your patience while I reviewed this. Everything looks solid to me, and I appreciate the contribution!
|
Hi @evansims any chance of releasing this soon? 🙂 (And thx for accepting our PR) |
Contributor
|
@evansims thx a lot |
Contributor
|
@komando82 this is amazing work, thank you! |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request intent is to add Interfaces to Final Classes. It is not a good pattern for public SDK to have final Classes without implemented Interfaces. I didn't add all Interfaces before check with you, since that requires more time for me to invest.
Changes
Things changed:
Contractfolder:Auth0Interface.php,TokenInterface.php,Token\ValidatorInterface.php,Api\AuthenticationInterface.php,Api\ManagementInterface.phpand allApi\Management/{Class}Interface.php.Management.phpclass magic method__callis removed and concrete methods added.ManagementTest.phpchangedBenefits for users (developers in my case) are big ones from my standpoint:
Introducing interfaces will not break any existing functionality since implementation is not changed.
References
This is referring to closed Issue : #575
Resolves #
Contributor Checklist