Skip to content

Unused imports left over from prior refactors (5 occurrences) #793

Description

@Zichen1028

Checklist

  • I have looked into the Readme and Examples, and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

Description

While reviewing the codebase, I found 5 unused imports that were left behind by two prior refactors. They're all confirmed unused (the imported class/method name doesn't appear anywhere else in the file besides the import line itself), and removing them does not affect behaviour - pure dead-code cleanup.

From #620 (9024318, Jan 2023) — this PR replaced a stored ObjectReader field with a fresh ObjectCodec obtained from the JsonParser at deserialise time, removing every usage of ObjectReader, but left the import behind in two places:

  • lib/src/main/java/com/auth0/jwt/impl/PayloadDeserializer.java (line 12): import com.fasterxml.jackson.databind.ObjectReader;
  • lib/src/test/java/com/auth0/jwt/impl/PayloadImplTest.java (line 6): import com.fasterxml.jackson.databind.ObjectReader;

From d8fe9a2 (Jun 2023) — this commit removed an assertThat(values, is(IsEmptyCollection.empty())) assertion but left the import:

  • lib/src/test/java/com/auth0/jwt/impl/PayloadDeserializerTest.java (line 14): import org.hamcrest.collection.IsEmptyCollection;

Two more, found via a repo-wide scan for the same pattern:

  • lib/src/test/java/com/auth0/jwt/JWTTest.java (line 15): import java.time.Duration;
  • lib/src/test/java/com/auth0/jwt/interfaces/VerificationTest.java (line 15): import static org.junit.Assert.assertThrows;

All 5 were verified locally — removing them compiles cleanly and the full test suite still passes.

I'll open a PR with these removals shortly and link it here.

Expected behaviour

No unused imports in the codebase; no functional change.

Reproduction

No repro required as this is not an actual bug.

Additional context

No response

java-jwt version

4.6.0

Java version

11

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThis points to a verified bug in the code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions