fix: Interop Layer#1037
Closed
guabu wants to merge 3 commits into
Closed
Conversation
5 tasks
poovamraj
suggested changes
Jan 24, 2025
|
Hello, I don't see this published yet when trying to install When can we expect it? I wanted to try it already |
Contributor
|
@EddyVinck we are waiting for community feedback but this will be released early next week. You can test this using npm command
|
Thanks! I just tested it with a fresh Ignite project and it appears to build on my Android emulator using the new architecture. |
|
@poovamraj I tested on both the new and old arch and the build was successful. |
Manikandan-saminathan
approved these changes
Jan 26, 2025
poovamraj
approved these changes
Jan 26, 2025
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
codegenConfigwhich was caused builds to fail when running under the new architecture. This is also inline with the reactwg recommendation:The changes have been tested with a sample app using the following React Native versions:
A follow-up PR will contain a complete migration to Turbo Modules.
The release is versioned as
4.1.0-interop.0and should be tagged as@interop.