chore: depend on authorizer-proto-go instead of vendored stubs#23
Merged
Conversation
Replace the hand-copied internal/genpb stubs with a real versioned module dependency (github.com/authorizerdev/authorizer-proto-go v0.1.0). - Removes the fragile cross-repo copy step that let the vendored stubs go stale (the drift that motivated authorizer#726). - proto-go regenerates itself straight from buf.build/authorizerdev/authorizer, so there is no manual copy to forget. - Import path internal/genpb/authorizer/v1 -> authorizer-proto-go/authorizer/v1 across 30 files; protovalidate/genproto demote to indirect. - REST transport is unaffected: grpc-gateway JSON uses the same proto message types, now sourced from the module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hand-copied
internal/genpbprotobuf/gRPC stubs with a real, versioned Go module dependency —authorizer-proto-gov0.1.0— mirroring theprometheus/client_modelpattern. This removes the cross-repo copy step that let the vendored stubs go stale (the drift behind authorizerdev/authorizer#726).Changes
internal/genpb/(generated stubs, ~17.4k lines).github.com/authorizerdev/authorizer-proto-go v0.1.0togo.mod;protovalidate/genprotodemote to indirect (now pulled transitively).internal/genpb/authorizer/v1->authorizer-proto-go/authorizer/v1across 30 files (aliasauthorizerv1unchanged).authorizer-proto-goregenerates itself directly frombuf.build/authorizerdev/authorizer(BSR) — no manual copy to forget.Testing
go build ./...,go vet ./...,gofmt -l— clean.go test ./test/live integration againstquay.io/authorizer/authorizer:2.4.0-rc.7(GraphQL + REST + gRPC, public + admin): 25 passed, 0 failed.Structural dependency change — leaving for human review, not self-merging.