chore!: regenerate stubs for id-only DeleteUser - #2
Merged
Conversation
Pulled from BSR via scripts/generate.sh after authorizerdev/authorizer#753. DeleteUserRequest.email is replaced by id; proto field 1 is reserved rather than reused, so an old client's email cannot silently decode as an id on a delete. BREAKING CHANGE: DeleteUserRequest.email is removed; use id. Requires server 2.4.0+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated via
./scripts/generate.shfrom BSR after authorizerdev/authorizer#753 landed and the schema was published. No hand-edits.Change
DeleteUserRequestlosesemailand gainsid. Verified against the built descriptor rather than by reading the diff:Plus the
DeleteUserdocstring inadmin_pb2_grpc.py.Email is not an identifier every account has — a phone-only signup has none — so an email-keyed delete could not reach those accounts at all.
BREAKING
DeleteUserRequest(email=...)no longer works; useDeleteUserRequest(id=...). Requires server 2.4.0+.Field 1 is reserved rather than reused: both fields are strings, so reusing tag 1 would let an old client's email decode silently as an id — wire-compatible, semantically wrong, on a delete path.
Version
Bumped
0.2.0rc0→0.2.0rc1, matching this repo's convention of bumping in the regeneration commit. The break lands inside the still-unreleased 0.2.0 RC line.authorizer-pythonpinsauthorizer-proto>=0.2.0rc0— a floating minimum with no upper bound, so it will pick this breaking release up automatically. The companion SDK PR handles the call-site change, but the loose pin means version skew is not actually prevented by the dependency spec.