Skip to content

Add null to urlProps type#37

Merged
lakhansamani merged 2 commits into
authorizerdev:mainfrom
kdichev:patch-1
Dec 5, 2022
Merged

Add null to urlProps type#37
lakhansamani merged 2 commits into
authorizerdev:mainfrom
kdichev:patch-1

Conversation

@kdichev

@kdichev kdichev commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

I don't need to use(yet) urlProps so I need to add urlProps={{}}, so with this PR i make urlProps also nullable

I don't need to use(yet) urlProps so I need to add `urlProps={{}}`, so with this PR i make urlProps also nullable
@kdichev kdichev mentioned this pull request Dec 4, 2022
@lakhansamani

Copy link
Copy Markdown
Contributor

This looks good,
Though this change should be added to other components as well.
I will do that

@kdichev Thanks for creating PR

@lakhansamani lakhansamani merged commit 4b2ba6f into authorizerdev:main Dec 5, 2022
kdichev added a commit to kdichev/authorizer-react that referenced this pull request Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants