chore: bump klauspost/compress to v1.18.7 for GO-2026-5841 - #745
Merged
Conversation
OOB read in compress/s2. Indirect, pulled in by prometheus/client_golang via zstd, and govulncheck reports it as not called — we use zstd, not s2 — but v1.18.7 is a drop-in fix. Leaves one module-level finding, GO-2026-5932 (x/crypto/openpgp unmaintained), which has no fixed version and no call path here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, the CI signal: the
govulncheckfailure onmainwas not a vulnerability report. That job died inSet up jobwithFailed to resolve action download info. Error: Service Unavailable— the ongoing GitHub Actions outage (Actions: major_outage, incident opened 15:22 UTC). It never scanned anything.Ran it locally instead. Two module-level findings, one fixable:
klauspost/compress/s2v1.18.7golang.org/x/crypto/openpgpunmaintainedklauspost/compressis indirect, viaprometheus/client_golang→zstd. govulncheck classes it as not called, which is right — the flaw is ins2and we usezstd— but v1.18.7 is a drop-in.GO-2026-5932 has no fixed version, so it cannot be resolved by upgrading, and
x/crypto/openpgpis not in any call path here. It will keep appearing under module results until the advisory or the module changes.After the bump, verified locally (Actions is still down, so CI cannot run):
govulncheck ./...→ 0 called, module findings 2 → 1go build ./...,go vet ./...→ cleanmake test→ 41 packages ok, 0 failuresmake smoke→ PASS (GraphQL + REST + gRPC + MCP)make lint→ 0 issues, prettier cleango.mod/go.sum only, no code change.