PR - Update 'ignoreHeader' Warning in README#758
Merged
authorjapps merged 2 commits intoauthorjapps:masterfrom Apr 16, 2026
Merged
PR - Update 'ignoreHeader' Warning in README#758authorjapps merged 2 commits intoauthorjapps:masterfrom
authorjapps merged 2 commits intoauthorjapps:masterfrom
Conversation
authorjapps
approved these changes
Apr 16, 2026
Owner
|
Thank you @IgnatiosSar for the changes. It's now merged. Thank you for your good work in implementing this end to end. Well done 🙌 |
Collaborator
Author
|
@authorjapps You're very welcome! Thanks for your help, the guidance, and the quick reviews. It was a pleasure working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR - Update 'ignoreHeader' Warning in README
Fixed Which Issue?
PR Branch
https://github.com/IgnatiosSar/zerocode/tree/update-readme
Motivation and Context
Update the warning for 'ignoreHeader' in README to match the migration guide
Checklist:
1. New Unit tests were added
2. Integration tests were added
3. Test names are meaningful
3.1 Feature manually tested and outcome is successful
4. PR doesn't break any of the earlier features for end users
5. PR doesn't break the HTML report features directly
/targetfolder and they look fine6. PR doesn't break any HTML report features indirectly
7. Branch build passed in CI
8. No 'package.*' in the imports
9. Relevant DOcumentation page added or updated with clear instructions and examples for the end user
10. Http test added to
http-testing-examplesmodule(if applicable) ?11. Kafka test added to
kafka-testing-examplesmodule(if applicable) ?