Pre-existing issue found during PR review
Surfaced by: PR #5 (its install job fails on ci/default-values.yaml, unrelated to that PR's changes)
Introduced in: #3 (cdf8a1a)
File: charts/authup/templates/admin-console/deployment.yaml
Description
#3 switched the admin console container args from client/web to
client/admin-console, but Chart.yaml still pins appVersion: "1.0.0-beta.58",
and that image's entrypoint only knows client/web. The container therefore exits
immediately:
==> Logs of container authup-...-admin-console-...
Unknown service: client/admin-console
which becomes CrashLoopBackOff and then:
Error: INSTALLATION FAILED: resource Deployment/.../authup-...-admin-console
not ready. status: InProgress, message: Available: 0/1
context deadline exceeded
#3's own commit message calls this out:
Must ship together with the appVersion bump to the first authup release that
contains the rename; the beta.58 image only knows client/web.
The two halves did not ship together.
client/admin-console exists in authup/authup master's entrypoint.sh, so the
rename is real, just not in a published image yet.
Why master's CI stayed green
ct install only runs against changed charts relative to the target branch, so a
push to master finds nothing to install and the job is effectively skipped. The
breakage only appears on pull requests, where every PR now fails install on the
very first scenario regardless of its content.
Suggested fix
Pick one:
- Revert the args to
client/web until the appVersion bump. Smallest change,
restores CI immediately, and matches what the published image actually accepts.
- Bump
appVersion to the first authup release whose image carries the
renamed entrypoint, and land it in the same commit as the args.
- Version-gate the args helper, or give the entrypoint a dual-selector
transition window in authup/authup, so the chart works across both images.
Option 1 is the fastest unblock; option 2 is the intended end state.
Pre-existing issue found during PR review
Surfaced by: PR #5 (its
installjob fails onci/default-values.yaml, unrelated to that PR's changes)Introduced in: #3 (
cdf8a1a)File:
charts/authup/templates/admin-console/deployment.yamlDescription
#3 switched the admin console container args from
client/webtoclient/admin-console, butChart.yamlstill pinsappVersion: "1.0.0-beta.58",and that image's entrypoint only knows
client/web. The container therefore exitsimmediately:
which becomes
CrashLoopBackOffand then:#3's own commit message calls this out:
The two halves did not ship together.
client/admin-consoleexists inauthup/authupmaster'sentrypoint.sh, so therename is real, just not in a published image yet.
Why master's CI stayed green
ct installonly runs against changed charts relative to the target branch, so apush to master finds nothing to install and the job is effectively skipped. The
breakage only appears on pull requests, where every PR now fails
installon thevery first scenario regardless of its content.
Suggested fix
Pick one:
client/webuntil the appVersion bump. Smallest change,restores CI immediately, and matches what the published image actually accepts.
appVersionto the first authup release whose image carries therenamed entrypoint, and land it in the same commit as the args.
transition window in
authup/authup, so the chart works across both images.Option 1 is the fastest unblock; option 2 is the intended end state.