chore: fix gradlew.bat line endings#171
Merged
Merged
Conversation
The dependabot Gradle-wrapper bump in 91809c3 re-stored gradlew.bat with CRLF bytes in the blob, undoing the earlier renormalization in cb1517e. Because .gitattributes declares *.bat text eol=crlf, git's clean filter normalizes to LF before hashing, so the working tree hash never matched the index hash and the file appeared perpetually modified. That broke the nightly "Update API" workflow: peter-evans/create-pull-request runs git reset --hard followed by git checkout -B, and the spurious "modified" gradlew.bat caused the checkout to abort.
vroldanbet
force-pushed
the
fix/gradlew-bat-line-endings
branch
from
67724e4 to
2a3a331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gradlew.batso the index stores LF while the working tree keeps CRLF, matching*.bat text eol=crlfin.gitattributes.peter-evans/create-pull-requestwith:error: Your local changes to the following files would be overwritten by checkout: gradlew.bat.Root cause
91809c3(dependabot Gradle wrapper bump 8.14-rc-1 → 9.3.1) committedgradlew.batwith CRLF bytes in the blob, undoing the earlier renormalization incb1517e. Withtext eol=crlfset, git's clean filter normalizes to LF before hashing, so the working-tree hash never matched the index hash and the file appeared perpetually modified.peter-evans/create-pull-requestdoesgit reset --hard origin/mainfollowed bygit checkout -B <branch>; the spurious "modified"gradlew.batmade the checkout abort.Failing run: https://github.com/authzed/authzed-java/actions/runs/26461205567/job/77909187573
Test plan
git statusis clean on a fresh checkout ofmain.Create PR for API updatestep succeeds.