re-enable tests#119
Merged
vroldanbet merged 2 commits intomainfrom Jun 3, 2024
Merged
Conversation
were removed under the wrong assumption they were being run elsewhere in CI
Closed
alecmerdler
approved these changes
Jun 3, 2024
Updates the unit tests so that async/await is not used with the 'done' callback. Also aligns the tests for the callback client to only use the 'done' callback-style tests rather than promises, which clarifies the usage of the client.
alecmerdler
force-pushed
the
re-enable-tests
branch
from
ddc5aad to
a4d3d93
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const client = NewClient( | ||
| generateTestToken('v1-namespace'), | ||
| 'localhost:50051', | ||
| generateTestToken("v1-namespace"), |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| const client = NewClient( | ||
| generateTestToken('v1-namespace-caveats'), | ||
| 'localhost:50051', | ||
| generateTestToken("v1-namespace-caveats"), |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| token = generateTestToken('v1-lookup'); | ||
|
|
||
| beforeEach((done) => { | ||
| token = generateTestToken("v1-lookup"); |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| beforeEach(async () => { | ||
| token = generateTestToken('v1-experimental-service'); | ||
| beforeEach((done) => { | ||
| token = generateTestToken("v1-experimental-service"); |
Check failure
Code scanning / CodeQL
Hard-coded credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
were removed under the
wrong assumption they were being
run elsewhere in CI