Skip to content

Use script instead of abandoned lib#164

Merged
tstirrat15 merged 1 commit intomainfrom
fix-version-setting-on-release
Oct 3, 2024
Merged

Use script instead of abandoned lib#164
tstirrat15 merged 1 commit intomainfrom
fix-version-setting-on-release

Conversation

@tstirrat15
Copy link
Copy Markdown
Contributor

Description

I went and checked the npm registry and the version wasn't v1.0.1. The version getting step didn't work as desired, so the version setting step was a read-only step rather than something that set the version. This fixes that.

The version getting action is 3 years out of date at this point, so we're using a script instead of it.

Changes

  • Use the script approach that works in other libs

Testing

Release and see that the version appears on npm.

@tstirrat15 tstirrat15 requested a review from a team October 3, 2024 17:24
@tstirrat15 tstirrat15 merged commit 4ad599b into main Oct 3, 2024
@tstirrat15 tstirrat15 deleted the fix-version-setting-on-release branch October 3, 2024 18:19
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants