Add bulk check permissions test #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
previously approved these changes
Oct 2, 2024
vroldanbet
reviewed
Oct 3, 2024
Contributor
There was a problem hiding this comment.
running buf generate works for me. running the buf YAML file as a script throws an error. It worked when I added --template back
Failure: :2:1 unknown field "version", expected one of [file]
2 | version: "v2"
2 | ^
:3:1 unknown field "plugins", expected one of [file]
3 | plugins:
3 | ^
:8:1 unknown field "inputs", expected one of [file]
8 | inputs:
8 | ^
vroldanbet
requested changes
Oct 3, 2024
Contributor
vroldanbet
left a comment
vroldanbet
left a comment
There was a problem hiding this comment.
Please add --template back to the buf yaml 🙏🏻
vroldanbet
approved these changes
Oct 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
Description
There wasn't a test validating that
check_bulk_permissionsworks, or example usage ofcheck_bulk_permissions. This addresses the first and partially addresses the second.Changes
Testing
Review. See that things pass.