Skip to content

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Nov 21, 2024

Fixes #80

Description

We vendored the validate.proto file because we had issues with generating a stub. This addresses the problem slightly more directly by letting Buf bring in the validate proto dependency from the source module, rather than us needing to maintain the vendor.

Notes

This also brings in other types from the import, which are functionally bloat, but this provides the simplest build process.

Changes

  • (chore) Make the lib only run checks on PR changes
  • add include_imports to cause generation of validate_pb.rb
  • Remove old vendor files

Testing

Review. See that everything is still green.

@tstirrat15 tstirrat15 requested a review from a team as a code owner November 22, 2024 17:33
@tstirrat15 tstirrat15 merged commit bc90e30 into main Nov 22, 2024
@tstirrat15 tstirrat15 deleted the bump-buf-version branch November 22, 2024 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate validate.proto codegen with main codegen

2 participants