Skip to content

Conversation

@ecordell
Copy link
Contributor

@ecordell ecordell commented Jun 3, 2025

This prevents infrastructure changes from disrupting more than 1 pod in a SpiceDB cluster at a time.

Fixes CTL-874

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like I'm expert on PDBs, but the code generally looks good to me.

One upshot of this is that rollouts will take longer because each pod is going to wait until it's up and healthchecking before the next one goes, right?

@ecordell ecordell added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 58f6372 Jun 4, 2025
11 checks passed
@ecordell ecordell deleted the pdb branch June 4, 2025 19:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
@ecordell
Copy link
Contributor Author

ecordell commented Jun 4, 2025

One upshot of this is that rollouts will take longer because each pod is going to wait until it's up and healthchecking before the next one goes, right?

That was already the case with the Deployment config we used, but this now also prevents other infrastructure changes from disrupting the cluster. We saw this when we rolled a config change to Nodes that rolled them all; the PDB would have prevented the next node from rolling until the minimum availability was back up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants