fix: goroutine leaks #2757
Merged
fix: goroutine leaks #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/tooling
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (74.32%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.00%
==========================================
Files 484 484
Lines 57307 57336 +29
==========================================
+ Hits 42591 42612 +21
- Misses 11731 11734 +3
- Partials 2985 2990 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
goroutine-leaks-fixes
branch
from
d86c005 to
b326cfb
Compare
github-actions
bot
added
area/cli
miparnisari
force-pushed
the
goroutine-leaks-fixes
branch
from
b326cfb to
efba795
Compare
miparnisari
force-pushed
the
goroutine-leaks-fixes
branch
6 times, most recently
from
701ad8a to
e63c319
Compare
miparnisari
force-pushed
the
goroutine-leaks-fixes
branch
3 times, most recently
from
1a145a0 to
f3fe0c1
Compare
miparnisari
commented
Dec 23, 2025
| var redispatch dispatch.Dispatcher | ||
|
|
||
| cts := caveattypes.TypeSetOrDefault(opts.caveatTypeSet) | ||
| if opts.upstreamAddr == "" { |
Contributor
Author
There was a problem hiding this comment.
FYI major change on the setup. Notice how before, redispatch's content was getting overwritten on line 307
tstirrat15
previously approved these changes
Jan 5, 2026
| } | ||
|
|
||
| // Start is async so that prepopulating doesn't block the server start. | ||
| // The caller must cancel the context before calling Close. |
Contributor
There was a problem hiding this comment.
Oof. This seems like a footgun.
miparnisari
force-pushed
the
goroutine-leaks-fixes
branch
from
f3fe0c1 to
fc069af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers: please see changes in
pkg/testutil/leakdetection.gointernal/dispatch/combined/combined.go