fix(metrics): inverted values for pgxpool_max_conns{read} and pgxpool… #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
==========================================
- Coverage 77.65% 77.62% -0.03%
==========================================
Files 472 472
Lines 49677 49677
==========================================
- Hits 38572 38556 -16
- Misses 8258 8269 +11
- Partials 2847 2852 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
fix-prom-crdb
branch
from
abdc88d to
747f24f
Compare
…_max_conns{write}
miparnisari
force-pushed
the
fix-prom-crdb
branch
from
747f24f to
3aa3f6c
Compare
squat
approved these changes
Dec 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_max_conns{write}
In #2707 I accidentally introduced a bug: max_conns for
readand forwriteare inverted.