Skip to content

Conversation

@tstirrat15
Copy link
Contributor

Description

The public.yaml integration test was failing because an assertion that didn't have associated rels was still returning resources. This ended up being because the subject in the datastore query referenced the base type instead of the subject's type.

I also refactored a few more tests.

Changes

  • Use the subject type in the datastore query
  • Refactor a few more tests

Testing

Review.

@tstirrat15 tstirrat15 requested a review from a team as a code owner January 16, 2026 22:58
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 16, 2026
barakmich
barakmich previously approved these changes Jan 16, 2026
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.66%. Comparing base (9f73d87) to head (66bea73).

Files with missing lines Patch % Lines
pkg/query/datastore.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2830      +/-   ##
==========================================
- Coverage   75.72%   75.66%   -0.05%     
==========================================
  Files         460      460              
  Lines       55048    55052       +4     
==========================================
- Hits        41678    41650      -28     
- Misses      10484    10509      +25     
- Partials     2886     2893       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15 tstirrat15 enabled auto-merge January 16, 2026 23:14
@tstirrat15 tstirrat15 added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 3b013e3 Jan 16, 2026
44 of 45 checks passed
@tstirrat15 tstirrat15 deleted the fix-datastore-query-behavior-for-lr branch January 16, 2026 23:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants