fix: lexing utf-8 characters #2836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2835
Description
See #2835. A user encountered an issue where non-ASCII characters in string literals were causing a lexer panic. This fixes that by changing how peeks and string literal lexing work.
The issue was that the code implicitly made an assumption that all of the peeked or accepted runes were the same width, which isn't necessarily going to be the case in unicode strings;
l.backup()will use the currently-set width, rather than the width of the rune that is being backed up over. Manually tracking the start position works around this problem.Changes
backupmultiple timesTesting
Review. See that tests pass.