Skip to content

chore: bump optgen to v0.2.3 #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tstirrat15 merged 1 commit into from
Jan 22, 2026
Merged

chore: bump optgen to v0.2.3 #2837

tstirrat15 merged 1 commit into from
Jan 22, 2026

Conversation

@ecordell
Copy link
Contributor

@ecordell ecordell commented Jan 21, 2026

Description

This bumps to the latest optgen which fixes a bunch of long standing issues:

  • it's significantly faster to generate
  • it doesn't matter if the existing code is compilable or not (preventing annoying loops where you need to delete generated code in order to regenerate it, but can't because the generated code is referenced)
  • removes runtime reflection in favor of generating debug methods directly (which have the added benefit of being easier to review for correctness, IMO)

Testing

This should basically be a no-op and completely backwards compatible. The one small change is that a helper you had to import is now a method.

References

ecordell/optgen#12

@ecordell ecordell requested a review from a team as a code owner January 21, 2026 20:15
@github-actions github-actions bot added area/cli Affects the command line area/api v1 Affects the v1 API area/datastore Affects the storage system area/dependencies Affects dependencies area/dispatch Affects dispatching of requests labels Jan 21, 2026
@ecordell ecordell closed this Jan 21, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
@ecordell ecordell reopened this Jan 21, 2026
@ecordell ecordell changed the title chore: bump optgen to v0.2.1 chore: bump optgen to v0.2.3 Jan 21, 2026
@ecordell ecordell force-pushed the optgen-bump branch 3 times, most recently from d263873 to ee45bbf Compare January 22, 2026 14:24
tstirrat15
tstirrat15 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 enabled auto-merge January 22, 2026 17:03
@tstirrat15 tstirrat15 added this pull request to the merge queue Jan 22, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@tstirrat15 tstirrat15 added this pull request to the merge queue Jan 22, 2026
Merged via the queue into authzed:main with commit dbd2687 Jan 22, 2026
43 of 45 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees

No one assigned

Labels

area/api v1 Affects the v1 API area/cli Affects the command line area/datastore Affects the storage system area/dependencies Affects dependencies area/dispatch Affects dispatching of requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ecordell @tstirrat15