ci: compare Go benchmarks properly #2865
Merged
+4
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
miparnisari
commented
Jan 29, 2026
| with: | ||
| path: "./cache/benchmark-data.json" | ||
| key: "${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-${{ steps.system-info.outputs.cpu-model }}-go-benchmark" | ||
| key: "${{ steps.get-main-branch-sha.outputs.sha }}-${{ runner.os }}-go-benchmark" |
Contributor
Author
There was a problem hiding this comment.
this was returning unknown, https://github.com/authzed/spicedb/actions/runs/21220346253/job/61055195969?pr=2805#step:7:13
which caused the cache key to not be found, therefore the comparison wasn't being done
barakmich
approved these changes
Jan 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.49%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2865 +/- ##
==========================================
+ Coverage 74.46% 74.49% +0.04%
==========================================
Files 484 484
Lines 57702 57702
==========================================
+ Hits 42964 42982 +18
+ Misses 11733 11720 -13
+ Partials 3005 3000 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
miparnisari
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue where PR's are not comparing against
main.