Skip to content

chore: hang filename off of ast nodes and refactor accordingly#2987

Draft
tstirrat15 wants to merge 1 commit intomainfrom
tstirrat/2986-developer-package-cleanup
Draft

chore: hang filename off of ast nodes and refactor accordingly#2987
tstirrat15 wants to merge 1 commit intomainfrom
tstirrat/2986-developer-package-cleanup

Conversation

@tstirrat15
Copy link
Copy Markdown
Contributor

Fixes #2986

Description

Things I noticed while reviewing #2965 but that I don't want to have blocking the release.

Changes

TODO

Testing

TODO

@github-actions github-actions Bot added area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.16%. Comparing base (b041b8f) to head (1b6449e).
⚠️ Report is 53 commits behind head on main.

Files with missing lines Patch % Lines
pkg/schemadsl/compiler/translator.go 25.00% 4 Missing and 2 partials ⚠️
pkg/schema/errors.go 33.34% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (52.16%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (b041b8f) and HEAD (1b6449e). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (b041b8f) HEAD (1b6449e)
25 14
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2987       +/-   ##
===========================================
- Coverage   74.92%   52.16%   -22.75%     
===========================================
  Files         500      217      -283     
  Lines       61229    22924    -38305     
===========================================
- Hits        45868    11956    -33912     
+ Misses      12160     9675     -2485     
+ Partials     3201     1293     -1908     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer Package Cleanup

1 participant