feat: metrics module#3120
Open
paegun wants to merge 6 commits into
Open
Conversation
…uction pattern of use.
github-actions
Bot
added
area/cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throughout, use of prometheus.Register and prometheus.Unregister lead to test isolation being compromised. This change makes the Prometheus Registerer an injectable.
As expected w/i #2829 , promauto use also needed to be removed.
Reverted #2957 which worked around the test isolation issue.
This is a more aggressive change than #3106 . This change replaces direct Prometheus usage w/i all business logic paths.
Testing
[X] Execute unit tests
[X] Execute integration tests
[X] Test w/ docker compose + Apache Benchmark
[X] Review metrics via Grafana dashboard
References
#2829