Add zed schema compile command#432
Merged
tstirrat15 merged 7 commits intomainfrom Feb 5, 2025
Merged
Conversation
tstirrat15
commented
Oct 30, 2024
tstirrat15
commented
Oct 30, 2024
tstirrat15
force-pushed
the
add-zed-schema-compile-command
branch
3 times, most recently
from
2dab9d0 to
4137a50
Compare
tstirrat15
force-pushed
the
add-zed-schema-compile-command
branch
from
8790ef6 to
df339c4
Compare
Contributor
Author
|
Evan pointed out that absolute paths don't seem to work, and that seems like a sane use case. I'll fix that. |
ecordell
reviewed
Feb 4, 2025
| # Local-only files | ||
| go.work | ||
| go.work.sum | ||
|
|
Contributor
There was a problem hiding this comment.
don't think these need to be ignored 3 times?
Contributor
Author
There was a problem hiding this comment.
Yeah I still haven't figured out merge conflict resolution with jujutsu 😅
tstirrat15
force-pushed
the
add-zed-schema-compile-command
branch
from
6d1285d to
9afa309
Compare
tstirrat15
force-pushed
the
add-zed-schema-compile-command
branch
from
9afa309 to
49a926e
Compare
ecordell
approved these changes
Feb 5, 2025
Contributor
ecordell
left a comment
ecordell
left a comment
There was a problem hiding this comment.
LGTM
Not blocking, but I do think the error message could be better when the file being referenced is missing:
9:18AM ERR terminated with errors error="failed to read schema file: open /Users/evan/Downloads/schemastesting/subjects.zed: no such file or directory"
Ideally this would say something about the import statement on line 1 of root.zed, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the first pass of the
zed schema compilecommand. It adds it under apreviewsubcommand so that we can release to the public without setting an expectation that the API is stable. This should allow us to do releases and get feedback without locking ourselves onto a particular course.Changes
cmdandcommandsTesting
Run
go build ./cmd/zed/...and then run./zed preview schema compile --helpand see that it's working