add more validate tests #491
Conversation
miparnisari
force-pushed
the
more-validation-tests
branch
2 times, most recently
from
5d7e394 to
859ae4a
Compare
| var errWithSource spiceerrors.WithSourceError | ||
| if errors.As(err, &errWithSource) { | ||
| ouputErrorWithSource(validateContents, errWithSource) | ||
| outputErrorWithSource(toPrint, validateContents, errWithSource) |
There was a problem hiding this comment.
Not sure how to hit this code path yet
|
|
||
| // Output errors | ||
| outputDeveloperErrorsWithLineOffset(validateContents, devErrs.InputErrors, schemaOffset) | ||
| outputDeveloperErrorsWithLineOffset(toPrint, validateContents, devErrs.InputErrors, schemaOffset) |
There was a problem hiding this comment.
Not sure how to hit this code path yet
There was a problem hiding this comment.
IIRC this and the other are some combination of compilation errors and typesystem errors. Grepping for DeveloperErr and ErrorWithSource should probably turn something up.
There was a problem hiding this comment.
JK you've already got some of that kind of thing in there...
miparnisari
force-pushed
the
more-validation-tests
branch
from
859ae4a to
b8f5a75
Compare
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
I like where this is headed
|
|
||
| // Output errors | ||
| outputDeveloperErrorsWithLineOffset(validateContents, devErrs.InputErrors, schemaOffset) | ||
| outputDeveloperErrorsWithLineOffset(toPrint, validateContents, devErrs.InputErrors, schemaOffset) |
There was a problem hiding this comment.
IIRC this and the other are some combination of compilation errors and typesystem errors. Grepping for DeveloperErr and ErrorWithSource should probably turn something up.
|
|
||
| // Output errors | ||
| outputDeveloperErrorsWithLineOffset(validateContents, devErrs.InputErrors, schemaOffset) | ||
| outputDeveloperErrorsWithLineOffset(toPrint, validateContents, devErrs.InputErrors, schemaOffset) |
There was a problem hiding this comment.
JK you've already got some of that kind of thing in there...
In preparation for #478, adding more tests to ensure we don't break existing behavior.