chore: fix self validation by pulling in most recent SpiceDB #624
+26
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
force-pushed
the
fix-self-validation
branch
from
75362d0 to
80759b4
Compare
miparnisari
previously approved these changes
Feb 5, 2026
tstirrat15
force-pushed
the
fix-self-validation
branch
from
80759b4 to
8394c3b
Compare
tstirrat15
commented
Feb 5, 2026
| // SpiceDB returns an error when no schema is defined, which is expected | ||
| require.Error(t, err) | ||
| assert.Contains(t, err.Error(), "No schema has been defined") | ||
| assert.Contains(t, err.Error(), "no schema has been defined") |
Contributor
Author
There was a problem hiding this comment.
This error message changed in the new version.
| relationships := []*core.RelationTuple{} | ||
|
|
||
| nsDefs, err := reader.ListAllNamespaces(ctx) | ||
| schemaReader, err := reader.SchemaReader() |
Contributor
Author
There was a problem hiding this comment.
These changes are to use the new SchemaReader interface and stop using a part of the interface that was removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 42.46% 42.46%
=======================================
Files 38 38
Lines 5032 5032
=======================================
Hits 2137 2137
Misses 2639 2639
Partials 256 256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
approved these changes
Feb 5, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #623
Description
This pulls in most recent
mainfor SpiceDB which fixes validation of schemas with theselfkeyword.Changes
Testing
Review. See that you can
go run ./cmd/zed/... validatethis schema: