Revise Node.dimmable property to exclude non-dimmable subnodes#122
Merged
Conversation
shbatm
force-pushed
the
dimmable_changes
branch
from
September 12, 2020 01:17
4961b7f to
631b18d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
Node.dimmablehas been depreciated in favor ofNode.is_dimmableto make the naming more consistent withis_lockandis_thermostat.Node.dimmablewill still work, however, plan for it to be removed in the future.Node.is_dimmablewill only include the first subnode for Insteon devices in type 1. This should represent the main (load) button for KeypadLincs and the light for FanLincs, all other subnodes (KPL buttons and Fan Motor) are not dimmable (fixes Issues with KPL Button Nodes #110)All Changes
is_lock,is_thermostat, andis_lockproperties of the Node class to be more consistent.General Notes
is_dimmableproperty of a node is not considered reliable. As of Version 2, there is no truly reliable "sorting" of device types within the PyISY module itself, the module is non-discriminate when allowing command calls to the ISY. It is expected that the code using this module takes additional steps to ensure only valid commands are called on the various device types or risk them being ignored by the ISY.