Kitti360 v0.0.1 #62
Merged
Kitti360 v0.0.1 #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PinholeCameraMetadata
Collaborator
|
Hi Jiabao, thanks a lot! The things you mention might be bugs. I will first merge nuScenes and then continue with this merge. |
… ego frame from imu to rear axle.
…of sensors. Remove reliance of environment file paths for kitti 360.
Collaborator
|
Hi @lanbo-xiao, Thanks for your great work on the KITTI dataset. 🔥 I am merging the changes now. There were a few minor things I ended up changing. I separated the Fisheye and Pinhole camera in the implementation for easier maintenance, enabled to preprocess (and store) the bounding boxes dynamically when calling the converter, and change how dataset paths are handled. If you have time, you could test out the changes and give feedback. Here are some KITTI-360 demo clips. https://youtu.be/trXxsQmTKz8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the KITTI-360 dataset, I believe it's ready to be merged, but I have two minor notes:
1、On lines 70-71, line 70 should be uncommented, and line 71 should be deleted. (This is to match my local dataset's organization.)
https://github.com/DanielDauner/123d/blob/7e12332a58801b6b3f7f926155740d981e936194/src/py123d/conversion/datasets/kitti_360/kitti_360_data_converter.py#L70
2、As for the configuration file below, I might have found a minor bug?
https://github.com/DanielDauner/123d/blob/7e12332a58801b6b3f7f926155740d981e936194/src/py123d/script/config/common/scene_builder/default_scene_builder.yaml#L4