Release SDK updates - #15
Conversation
scripts/mock EMBEDDED_SPEC conflict resolved by taking the new gen-head version; tracking file updated accordingly. Stainless-Generated-From: 96ea59d391e721e9f06a0e9f526cf424554a1f5e
Stainless-Generated-From: ec3cebf78b5415d4f7970eda786b518f221a2bc5
Stainless-Generated-From: c13792b8c4daac5fb8db2dda06d2016c8d88e742
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (21)
📝 WalkthroughWalkthroughIntroduces paginated file listing responses for synchronous and asynchronous clients. Expands upload ChangesAPI behavior and release updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant FilesResource
participant Pagination
Client->>FilesResource: list()
FilesResource->>Pagination: request paginated file list
Pagination-->>Client: page.files and page.meta
Client->>Pagination: iterate or request next page
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/api_resources/test_uploads.py (1)
80-91: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winKeep one regression case for comma-separated string tags.
These updates only exercise the new list form, but
create_from_url()still publicly acceptsstras well. Add one sync and one async assertion that pass a comma-separated string so CI still guards the legacy input shape.Also applies to: 180-191
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/api_resources/test_uploads.py` around lines 80 - 91, The upload tests only cover the new list-style tags input, but create_from_url() still accepts legacy comma-separated string tags. Update the existing create_from_url coverage in test_uploads.py by adding one sync and one async assertion that pass a string tags value, alongside the current UploadCreateFromURLResponse checks. Use the create_from_url method in both the synchronous client test and the async variant so CI continues to guard the old input shape.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Line 3: The runtime version source is out of sync because pyproject.toml was
updated but src/autorender/_version.py still hardcodes the old release version.
Update the version constant in _version.py to match the value declared in
pyproject.toml, and make sure any version-retrieval logic that feeds the
client/user-agent uses that shared source so the reported release stays current.
---
Outside diff comments:
In `@tests/api_resources/test_uploads.py`:
- Around line 80-91: The upload tests only cover the new list-style tags input,
but create_from_url() still accepts legacy comma-separated string tags. Update
the existing create_from_url coverage in test_uploads.py by adding one sync and
one async assertion that pass a string tags value, alongside the current
UploadCreateFromURLResponse checks. Use the create_from_url method in both the
synchronous client test and the async variant so CI continues to guard the old
input shape.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d556779c-7e2d-4c05-80cd-9f927c1d0642
📒 Files selected for processing (9)
.github/workflows/stlc-promote.yml.github/workflows/stlc-sync-from-production.ymlCHANGELOG.mdREADME.mdpyproject.tomlscripts/mocksrc/autorender/resources/uploads.pysrc/autorender/types/upload_create_from_url_params.pytests/api_resources/test_uploads.py
💤 Files with no reviewable changes (2)
- .github/workflows/stlc-sync-from-production.yml
- .github/workflows/stlc-promote.yml
Stainless-Generated-From: 4b04eaec527725f87b0358f7422c28f31088ecf9
714a11f to
86fbf6b
Compare
…e) (#1) Mechanical cleanup after the org rename autorenderhq -> autorender. Updates GitHub org/repo references (URLs, workflow repo guards, uses:, package metadata, docs). Intentionally left unchanged: SDK mount paths (autorenderhq-<lang>), Linear workspace URL, Sentry org slug. No logic changed (string references only). Co-authored-by: Geetha Karthick <geetha.karthick@seaant.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
01e7417 to
3b03a2b
Compare
Stainless-Generated-From: 7d953737769ed9b4824d831bc21846e8071d99bc
2272ff8 to
62e9c20
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
tests/api_resources/test_files.py (1)
64-95: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd page-traversal tests for both clients.
The current tests validate only the initial response type. They do not validate
filesextraction,meta.hasNext=False, page-number advancement, or preservation of the original query parameters.
tests/api_resources/test_files.py#L64-L95: Mock at least two pages and assert synchronous iteration requests page 2 and stops whenhasNextis false.tests/api_resources/test_files.py#L224-L255: Add the equivalent asynchronous iteration and next-page assertions.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/api_resources/test_files.py` around lines 64 - 95, Extend tests/api_resources/test_files.py lines 64-95 with synchronous pagination coverage around the files client tests: mock at least two pages, assert extracted files, verify the second request advances to page 2 while preserving the original query parameters, and confirm iteration stops when meta.hasNext is false. Add equivalent asynchronous iteration and next-page assertions at tests/api_resources/test_files.py lines 224-255.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api.md`:
- Line 25: Update the return-type link in the files list API documentation so
SyncPagePagination links to its definition in pagination.py, while
FileListResponse remains separately linked to file_list_response.py.
In `@CHANGELOG.md`:
- Line 62: Update CHANGELOG.md to eliminate the duplicate 0.1.0 release
headings: merge the May 15, 2026 legacy entries into the existing 0.1.0 section
or rename that legacy section, leaving one unambiguous 0.1.0 release entry.
In `@CONTRIBUTING.md`:
- Line 74: Update the installation command example in CONTRIBUTING.md to satisfy
markdownlint MD014 by removing the leading shell prompt marker, or add a
representative output block showing the command’s result.
In `@README.md`:
- Around line 167-170: Update the README example around first_page so accessing
the optional meta field cannot raise an AttributeError; guard first_page.meta
before reading page, while preserving the existing page-number output when
metadata is present.
---
Nitpick comments:
In `@tests/api_resources/test_files.py`:
- Around line 64-95: Extend tests/api_resources/test_files.py lines 64-95 with
synchronous pagination coverage around the files client tests: mock at least two
pages, assert extracted files, verify the second request advances to page 2
while preserving the original query parameters, and confirm iteration stops when
meta.hasNext is false. Add equivalent asynchronous iteration and next-page
assertions at tests/api_resources/test_files.py lines 224-255.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 695af4f5-4302-4f25-a73f-9fa8fe24544c
📒 Files selected for processing (21)
.github/workflows/publish-pypi.yml.github/workflows/release-doctor.yml.github/workflows/release-please.yml.github/workflows/stlc-promote.yml.github/workflows/stlc-sync-from-production.ymlCHANGELOG.mdCONTRIBUTING.mdREADME.mdapi.mdpyproject.tomlscripts/mocksrc/autorender/_files.pysrc/autorender/pagination.pysrc/autorender/resources/files.pysrc/autorender/resources/folders.pysrc/autorender/resources/multipart_uploads.pysrc/autorender/resources/uploads.pysrc/autorender/types/file_list_response.pysrc/autorender/types/upload_create_from_url_params.pytests/api_resources/test_files.pytests/api_resources/test_uploads.py
💤 Files with no reviewable changes (2)
- .github/workflows/stlc-sync-from-production.yml
- .github/workflows/stlc-promote.yml
🚧 Files skipped from review as they are similar to previous changes (4)
- scripts/mock
- src/autorender/types/upload_create_from_url_params.py
- tests/api_resources/test_uploads.py
- src/autorender/resources/uploads.py
|
|
||
| - <code title="get /api/v1/files/{fileNo}">client.files.<a href="./src/autorender/resources/files.py">retrieve</a>(file_no) -> <a href="./src/autorender/types/file_retrieve_response.py">FileRetrieveResponse</a></code> | ||
| - <code title="get /api/v1/files">client.files.<a href="./src/autorender/resources/files.py">list</a>(\*\*<a href="src/autorender/types/file_list_params.py">params</a>) -> <a href="./src/autorender/types/file_list_response.py">FileListResponse</a></code> | ||
| - <code title="get /api/v1/files">client.files.<a href="./src/autorender/resources/files.py">list</a>(\*\*<a href="src/autorender/types/file_list_params.py">params</a>) -> <a href="./src/autorender/types/file_list_response.py">SyncPagePagination[FileListResponse]</a></code> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Link SyncPagePagination to its definition.
Line 25 links SyncPagePagination[FileListResponse] to file_list_response.py. That file does not define SyncPagePagination. Link the wrapper to src/autorender/pagination.py and link FileListResponse separately.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@api.md` at line 25, Update the return-type link in the files list API
documentation so SyncPagePagination links to its definition in pagination.py,
while FileListResponse remains separately linked to file_list_response.py.
| * trigger release-please ([8db5acc](https://github.com/autorender/autorender-python/commit/8db5acc865fce568f3ebb33c2e2536d9e84a41a6)) | ||
| * update stlc custom-code tracking files ([505f95e](https://github.com/autorender/autorender-python/commit/505f95e9e6b66928d05ffa5b630102fdfe3b5e3e)) | ||
|
|
||
| ## [0.1.0](https://github.com/autorender/autorender-python/compare/v0.0.1...v0.1.0) (2026-05-25) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Avoid duplicate 0.1.0 release headings.
CHANGELOG.md contains two 0.1.0 sections dated May 25, 2026 and May 15, 2026. Merge the legacy entries under one version heading, or rename the legacy section so the release history has one unambiguous 0.1.0 entry.
Also applies to: 108-108
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` at line 62, Update CHANGELOG.md to eliminate the duplicate
0.1.0 release headings: merge the May 15, 2026 legacy entries into the existing
0.1.0 section or rename that legacy section, leaving one unambiguous 0.1.0
release entry.
| first_page = await client.files.list() | ||
|
|
||
| print(f"page number: {first_page.meta.page}") # => "page number: 1" | ||
| for file in first_page.files: |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Guard access to optional meta.
first_page.meta can be None. Line 169 can raise AttributeError for a response without metadata. Guard meta before reading meta.page, or document that this endpoint always returns metadata.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 167 - 170, Update the README example around
first_page so accessing the optional meta field cannot raise an AttributeError;
guard first_page.meta before reading page, while preserving the existing
page-number output when metadata is present.
3 participants
620a8ec Merge branch 'main' of https://github.com/autorenderhq/sdk-config
1b70be9 chore: sync openapi.json from northstar-server
4daca99 reseal python custom-code after stlc 0.2.1 upgrade
207ad4f Build SDK
Summary by CodeRabbit
New Features
tagsas either a comma-separated string or an array of tags.Documentation
Chores