Skip to content

prevent reverse(uint64_t) from being called#10

Merged
veqcc merged 1 commit into
mainfrom
fix/reverse-bug
Mar 19, 2026
Merged

prevent reverse(uint64_t) from being called#10
veqcc merged 1 commit into
mainfrom
fix/reverse-bug

Conversation

@veqcc
Copy link
Copy Markdown

@veqcc veqcc commented Mar 19, 2026

The current implementation of reverse is buggy.

        int reverse(uint64_t i)
        {
            return (reverse(uint32_t(i)) << 32) | reverse(uint32_t(i >> 32));
        }

Let's prevent it being called until it is fixed.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc self-assigned this Mar 19, 2026
@veqcc veqcc requested a review from amadeuszsz March 19, 2026 05:29
@veqcc veqcc marked this pull request as ready for review March 19, 2026 05:44
@veqcc veqcc merged commit b1bc910 into main Mar 19, 2026
1 check passed
@veqcc veqcc deleted the fix/reverse-bug branch March 19, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant