Make node start the round after replication notarization - #471
Merged
Conversation
Currently, if a node replicates a notarization it will advance to the next round, but will not start it. This commit makes sure it starts the round in case it has advanced past the replicated seqs/rounds, just as we do for finalizations. Added a unit test for both notarization and finalization, that a node proposes a block if it's the leader of the round that is after the round it replicated. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
samliok
approved these changes
Jul 28, 2026
| } | ||
|
|
||
| func TestLeaderStartsRoundAfterReplicatedQuorumRound(t *testing.T) { | ||
| // This test makes sure that a node that replicates a notarization or a finalization, |
Collaborator
There was a problem hiding this comment.
nit: is it not standard to add these comments above the function
Collaborator
Author
There was a problem hiding this comment.
No! That's Claude's standard, not ours!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a node replicates a notarization it will advance to the next round, but will not start it.
This commit makes sure it starts the round in case it has advanced past the replicated seqs/rounds, just as we do for finalizations.
Added a unit test for both notarization and finalization, that a node proposes a block if it's the leader of the round that is after the round it replicated.