feat(params): Add AfterExecutingTransaction hook#294
Merged
Conversation
alarso16
changed the title
AfterExecutingTransaction hook
alarso16
marked this pull request as ready for review
July 17, 2026 16:51
powerslider
reviewed
Jul 20, 2026
powerslider
reviewed
Jul 20, 2026
powerslider
reviewed
Jul 20, 2026
ARR4N
reviewed
Jul 20, 2026
powerslider
approved these changes
Jul 20, 2026
rahulmutt-ava
approved these changes
Jul 20, 2026
ARR4N
approved these changes
Jul 20, 2026
ARR4N
left a comment
ARR4N
left a comment
Collaborator
There was a problem hiding this comment.
No need for me to re-review the changes unless you want me to. Feel free to merge if you'd like.
alarso16
enabled auto-merge (squash)
July 20, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Although SAE could avoid this since they wrap
core.AppyTransaction, there's a lot of call sites that all require this behavior.How this works
Uses
TransitionDbto add potential additional operations after the message is fully applied. Care is taken regarding execution invalidation.How this was tested
New UT