Skip to content

Add indicator of default/changed to simulationname and report - #780

Merged
fso42 merged 2 commits into
masterfrom
hashIndicator
Dec 15, 2022
Merged

Add indicator of default/changed to simulationname and report#780
fso42 merged 2 commits into
masterfrom
hashIndicator

Conversation

@fso42

@fso42 fso42 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor
  • adds D/C to indicate default/changed parameter set in simulation name
  • Also adds info and changed parameters to report

@fso42 fso42 added the enhancement New feature or request label Nov 14, 2022
@fso42 fso42 self-assigned this Nov 14, 2022
@codecov

codecov Bot commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 75.37% // Head: 75.49% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (99f9017) compared to base (cc14e44).
Patch coverage: 93.70% of modified lines in pull request are covered.

❗ Current head 99f9017 differs from pull request most recent head 110c998. Consider uploading reports for the commit 110c998 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   75.37%   75.49%   +0.12%     
==========================================
  Files          59       59              
  Lines       12583    12665      +82     
==========================================
+ Hits         9484     9562      +78     
- Misses       3099     3103       +4
Impacted Files Coverage Δ
avaframe/com3Hybrid/com3Hybrid.py 0.00% <0.00%> (ø)
avaframe/com1DFA/deriveParameterSet.py 82.86% <90.47%> (+0.62%) ⬆️
avaframe/com1DFA/com1DFA.py 92.97% <91.11%> (-0.18%) ⬇️
avaframe/in3Utils/fileHandlerUtils.py 85.84% <91.30%> (+0.26%) ⬆️
avaframe/com1DFA/com1DFATools.py 98.11% <96.42%> (-1.89%) ⬇️
avaframe/in1Data/getInput.py 97.66% <97.05%> (-1.71%) ⬇️
avaframe/in3Utils/cfgUtils.py 88.41% <98.03%> (+0.29%) ⬆️
avaframe/out1Peak/outPlotAllPeak.py 98.23% <100.00%> (+0.03%) ⬆️
avaframe/com1DFA/DFAfunctionsCython.pyx 87.70% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fso42
fso42 requested review from awirb and matthiasto November 18, 2022 08:04
@fso42
fso42 requested review from awirb and removed request for awirb and matthiasto December 7, 2022 19:40
@fso42 fso42 added this to the Version 1.4 milestone Dec 7, 2022
awirb
awirb reviewed Dec 12, 2022
View reviewed changes
Comment thread avaframe/com1DFA/com1DFA.py
@fso42
Add indicator of default/changed to simulationname and report
ed5649e 
	- Add function to compare simcfg to default cfg for com1DFA; adresses #762
	- Add changed parameter values to report; fixes #750 #715
	- Add handling of old filenames; pytests
@fso42

fso42 commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

Standardtests ok

@fso42
Add log prints to cfgUtils to avoid confusions
110c998 
	- Remove redundant report items
	- valRef fix
@qlty-cloud-legacy

qlty-cloud-legacy Bot commented Dec 15, 2022

Copy link
Copy Markdown

Code Climate has analyzed commit 110c998 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.5% (0.0% change).

View more on Code Climate.

@fso42
fso42 merged commit b6548bd into master Dec 15, 2022
@fso42
fso42 deleted the hashIndicator branch December 15, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awirb awirb awirb approved these changes

Assignees

@fso42 fso42

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 1.4

Development

Successfully merging this pull request may close these issues.

2 participants

@fso42 @awirb