[HttpClient] Improve error when no client implementation found #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the: `3. Using JDK 23+, and need to set property <maven.compiler.proc>full</maven.compiler.proc>` ... just to be a bit more explicit. The `avaje-http-client-generator dependency was not available` is accurate but perhaps it's good to explicitly mention the maven.compiler.proc full issue.
SentryMan
reviewed
Nov 26, 2025
| + "1. Missing @Client or @Client.Import annotation.\n" | ||
| + "2. The avaje-http-client-generator dependency was not available during compilation\n"); | ||
| + "2. The avaje-http-client-generator dependency was not available during compilation\n" | ||
| + "3. Using JDK 23+, and need to set property <maven.compiler.proc>full</maven.compiler.proc>\n"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| + "3. Using JDK 23+, and need to set property <maven.compiler.proc>full</maven.compiler.proc>\n"); | |
| + (Runtime.version().feature() >= 23 | |
| ? "3. Maven property <maven.compiler.proc>full</maven.compiler.proc> was not set when compiling\n" | |
| : "")); |
Contributor
There was a problem hiding this comment.
The suggested change wouldn't have helped for the actual case which was a bit weird - IDE generated the code, maven didn't, code was published and use on ANOTHER JDK (as part of an integration test that can't run locally yet) ... and failed there on a different JDK.
So the Runtime.version().feature() >= 23 wouldn't help for this scenario.
Contributor
There was a problem hiding this comment.
Yeah, it feels like a pretty unique set of circumstances ... but I'm kinda feeling that it's better to have the reason in there anyway.
SentryMan
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the:
3. Using JDK 23+, and need to set property <maven.compiler.proc>full</maven.compiler.proc>... just to be a bit more explicit. The
avaje-http-client-generator dependency was not availableis accurate but perhaps it's good to explicitly mention the maven.compiler.proc full issue.