-
Notifications
You must be signed in to change notification settings - Fork 1.4k
use empower-core for better assertion tracking and performance
#330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
api.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crap, meant to move that to the top of the file.
|
I like this idea 👍! |
|
Oh wow, something incredible happened, AppVeyor passed, but Travis failed. |
My whole world view is shaken. |
|
Looks like it's because I used scoped packages, and our travis script doesn't upgrade us to NPM 3. Not sure what we should do here. Should we bump travis to use NPM 3? Then all our CI is using NPM 3, is that a problem? |
|
@vdemedes - I just updated this to use the |
|
@vdemedes FYI: Some documentation on the recent changes to @sindresorhus @vdemedes - How should I proceed w/ regard to
|
|
@jamestalmage @vdemedes @sindresorhus I just released empower-core 0.2.0. |
|
👍 LGTM when the dependency is updated to ⬆️ and tests are passing. @twada Does the changes look good to you? |
|
@sindresorhus Looks good to me when bumped to empower-core 0.2.0 |
|
Dependency bumped 👍 |
3c49598 to
2539a1b
Compare
empower-core for better assertion tracking and performance.empower-core for better assertion tracking and performance
|
just rebased, but there weren't any conflicts. Not sure why GH was suggesting I "update branch" |
|
@jamestalmage I think it was because of lgtm.co. |
|
Great stuff @jamestalmage! |

This switches us to the (much) lighter weight
empower-core.empower-coredoes not render the pretty assertion graphs in the forked processes. So we need to useempower-formatters in the main process to finalize the enhancement. The browserified build ofempower-coreis 90% smaller than empower. However, we won't see much of that benefit until we move Babel transpiling to the main process as well (since thepower-asserttransform has a largely overlapping dependency graph withempower).The immediate benefit is that this provides a very easy way to track assertions and methods which will be beneficial to TAP support.
It currently relies on the initial changes made in twada/empower-core#2, but it will be trivial to update once that is merged and deployed. Currently it points to a dependency in the
@jamestalmagenamespace so as not to reintroduce a git dependency which seems to give some people problems.