Skip to content

Conversation

@jamestalmage
Copy link
Contributor

This switches us to the (much) lighter weight empower-core.

empower-core does not render the pretty assertion graphs in the forked processes. So we need to use empower-formatters in the main process to finalize the enhancement. The browserified build of empower-core is 90% smaller than empower. However, we won't see much of that benefit until we move Babel transpiling to the main process as well (since the power-assert transform has a largely overlapping dependency graph with empower).

The immediate benefit is that this provides a very easy way to track assertions and methods which will be beneficial to TAP support.

It currently relies on the initial changes made in twada/empower-core#2, but it will be trivial to update once that is merged and deployed. Currently it points to a dependency in the @jamestalmage namespace so as not to reintroduce a git dependency which seems to give some people problems.

api.js Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap, meant to move that to the top of the file.

@vadimdemedes
Copy link
Contributor

I like this idea 👍!

@vadimdemedes
Copy link
Contributor

Oh wow, something incredible happened, AppVeyor passed, but Travis failed.

@jamestalmage
Copy link
Contributor Author

Oh wow, something incredible happened, AppVeyor passed, but Travis failed.

My whole world view is shaken.

@jamestalmage
Copy link
Contributor Author

Looks like it's because I used scoped packages, and our travis script doesn't upgrade us to NPM 3. Not sure what we should do here. Should we bump travis to use NPM 3? Then all our CI is using NPM 3, is that a problem?

@jamestalmage
Copy link
Contributor Author

@vdemedes - I just updated this to use the empower-core API @twada and I agreed on. It is still going to fail on travis because I am using a scoped package. I think you are pretty safe to start exploring how to use this for your TAP integration though.

@jamestalmage
Copy link
Contributor Author

@vdemedes FYI: Some documentation on the recent changes to empower-core.

@sindresorhus @vdemedes - How should I proceed w/ regard to npm 1 not supporting scoped builds?

  1. Do we just want to add npm i -g npm@3 as the before_script? This would mask any errors that only surface with the NPM 2 directory structure.
  2. Do we want to only upgrade to npm@2-latest on Node 0.10 and stick with the default elsewhere?
  3. Just skip it and wait for @twada to ship those changes so we can bump versions? I'm sure @twada will get it done fast, but it would be nice to have a solution in place that allowed us to deploy hotfixes to npm in the future.

@twada
Copy link
Contributor

twada commented Dec 13, 2015

@jamestalmage @vdemedes @sindresorhus I just released empower-core 0.2.0.

@sindresorhus
Copy link
Member

👍 LGTM when the dependency is updated to ⬆️ and tests are passing.

@twada Does the changes look good to you?

@twada
Copy link
Contributor

twada commented Dec 13, 2015

@sindresorhus Looks good to me when bumped to empower-core 0.2.0

@jamestalmage
Copy link
Contributor Author

Dependency bumped 👍

@sindresorhus sindresorhus changed the title [WIP] use empower-core for better assertion tracking and performance. use empower-core for better assertion tracking and performance Dec 13, 2015
@jamestalmage
Copy link
Contributor Author

just rebased, but there weren't any conflicts. Not sure why GH was suggesting I "update branch"

@vadimdemedes
Copy link
Contributor

@jamestalmage I think it was because of lgtm.co.

@sindresorhus
Copy link
Member

Landed! :)

tumblr_mndj28lzs21qdlh1io1_250

@jamestalmage jamestalmage deleted the use-empower-core branch December 13, 2015 19:40
@vadimdemedes
Copy link
Contributor

Great stuff @jamestalmage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants