Skip to content

Conversation

@twada
Copy link
Contributor

@twada twada commented Dec 15, 2015

This PR removes empower from dependencies since it is replaced with new empower-core.

I gave LGTM to #330 but I missed this point. So sorry..

@jamestalmage
Copy link
Contributor

LGTM.
I just noticed the same thing.
How much does this affect our download size? Is worth releasing a 0.8.1?

I am guessing the impact is actually pretty minimal (most of the same dependencies are brought in anyways between babel-plugin-espower, power-assert-formatter, and power-assert-renderer.

@jamestalmage
Copy link
Contributor

@twada - don't worry about that test. It is super flaky and not the fault of this change. See #335

@twada
Copy link
Contributor Author

twada commented Dec 15, 2015

How much does this affect our download size? Is worth releasing a 0.8.1?
I am guessing the impact is actually pretty minimal

Trivial under npm@3, still minimal under npm@2.
So it's okay to ship this with other PRs.

sindresorhus added a commit that referenced this pull request Dec 15, 2015
remove `empower` from dependencies since it is replaced with `empower…
@sindresorhus sindresorhus merged commit 1827cb2 into avajs:master Dec 15, 2015
@sindresorhus
Copy link
Member

It can wait until the next release.

@twada
Copy link
Contributor Author

twada commented Dec 15, 2015

@sindresorhus @jamestalmage Thanks!

@twada twada deleted the remove-old-empower branch December 15, 2015 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants