ci(release): pin npm publish job to node 24 + npm ^12 - #487
Merged
Conversation
The npm publish job pinned node 20 but upgraded npm with @latest; when @latest became npm 12 (engines: node >=22.22.2) the upgrade step failed with EBADENGINE and the v0.27.0 npm publish never ran. Pin the npm major and pair it with node 24 so a future npm major bump cannot silently break the job again.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish to npmjob failed before publishing: the job pins node 20 but upgrades npm vianpm install -g npm@latest, and @latest now resolves to npm 12 whose engines require node ≥22.22.2 — EBADENGINE, job dead. Pin node 24 +npm@^12and pair them explicitly so a future npm major can't silently break the release pipeline again.npm publishfromnpm/(already version-stamped) with a granular token.Test plan
gh workflow listloads it)