fix(tui): mention tags use forward slashes on every platform - #499
Merged
Conversation
The <file path="…"> label came from to_string_lossy on the workspace-relative path, which serializes with backslashes on Windows. The tag is model-facing text: the same mention must produce identical output regardless of host OS. Join the path components with forward slashes explicitly. Fixes the three Windows failures in the mention suite (the existing assertions already encode the forward-slash contract, so they now pass on Windows and keep guarding it).
This was referenced Jul 25, 2026
Merged
8 tasks
emal-avala
added a commit
that referenced
this pull request
Jul 25, 2026
The Windows forward-slash fix for @ mention labels shipped after the section was stamped and was missing from the release notes.
emal-avala
added a commit
that referenced
this pull request
Jul 27, 2026
The Windows forward-slash fix for @ mention labels shipped after the section was stamped and was missing from the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<file path="…">label in @ mention expansion came fromto_string_lossyon the workspace-relative path, which serializes with backslashes on Windows — the model-facing tag differed by host OS, and the three mention tests fail on Windows CI (currently blocking the release PR Release v0.28.0 #496 run). The label is now built by joining path components with/explicitly. No behavior change on unix.Test plan
cargo test -p agent-code --bin agent -- mentions(30 green locally)rustfmt --checkon the touched file