ci: run the gate on stacked pull requests - #533
Merged
Conversation
The CI workflow only triggered on pull_request targeting main, so a PR based on another feature branch ran nothing. Three such PRs are open now (#531, #532) and neither has been compiled, linted or tested by CI. That is worse than failing. `gh pr checks` reports no failures because there is nothing to fail, and the PR page shows no red — a stacked PR looks indistinguishable from a passing one. Dropping the branch filter means any pull request runs the gate, whatever it targets. The push trigger keeps its main-only filter, so this does not add a run per branch push — only per PR. The client workflows already had no branch filter; this brings the Rust gate in line with them.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlonly triggered on pull requests targetingmain:So a PR based on another feature branch ran nothing. Two are open right now — #531 (base
feat/session-picker) and #532 (basefeat/session-switching) — and neither has been compiled, linted or tested by CI.Why this is worse than failing
gh pr checksreports no failures, because there is nothing to fail. The PR page shows no red. A stacked PR is indistinguishable from a passing one in every surface that shows a green tick — including automation that gates on "no failing checks".I hit exactly that: I reported this chain as green earlier in the session on the strength of
fail:none, which was true and meaningless.Fix
Drop the branch filter so any pull request runs the gate, whatever it targets. The push trigger keeps its
main-only filter, so this does not add a run per branch push — only per PR.The client workflows (
client-ci,client-playwright,client-e2e) already have no branch filter; this brings the Rust gate in line with them.Verified separately
feat/session-rosterdoes pass — 785 bin tests,clippy --all-targets -- -D warningsandfmt --checkclean,cargo test --workspace --all-targetsgreen apart from the 3bwrap_*tests that fail on this host withsetting up uid map: Permission denied. That was checked locally, which is precisely the gap this PR closes: it should not have needed checking by hand.