fix(tui): resolve resume project root off the event loop - #565
Merged
Conversation
finish_cwd_adoption awaited project_root_for on the sole event-loop future after chdir, so a slow git rev-parse or marker walk froze redraw and Ctrl+C. Resolve the root in the existing resume spawn_blocking preflight (same task as config load) and pass it in; adoption itself is now synchronous and does no filesystem detection.
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finish_cwd_adoptionawaitedproject_root_foron the event-loop future afterchdir, freezing redraw/Ctrl+C on slow mounts or large repos.spawn_blockingpreflight (with config load), using the one async detector viaHandle::block_on— no sync twin.finish_cwd_adoptionis now sync and takes a precomputed root.Fixes #551.
Test plan
finish_cwd_adoptiondoes not callproject_root_for/resolve_resume_project_root