feat(tui): resume recent sessions from the launch surface - #580
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bea93666a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let checks = | ||
| agent_code_lib::services::diagnostics::run_local(cwd_path, &cfg_snapshot).await; |
There was a problem hiding this comment.
When a local probe stalls—for example, git or df against an unavailable network-mounted working directory—this await prevents terminal setup and the event loop from starting. run_local still launches several unbounded subprocesses sequentially, so excluding HTTP requests does not guarantee a responsive first frame, and Ctrl+C cannot be processed by the TUI while startup is stuck. Run these probes after the initial draw with cancellation, or apply timeouts.
AGENTS.md reference: AGENTS.md:L125-L125
Useful? React with 👍 / 👎.
| let checks = | ||
| agent_code_lib::services::diagnostics::run_local(cwd_path, &cfg_snapshot).await; |
There was a problem hiding this comment.
On native Windows, where this CLI and TUI are supported (docs/src/faq.md:24-30), run_local invokes which for every required tool. Since which is not normally available from PowerShell or Command Prompt, each spawn fails and is converted into a failed check even when git and rg are installed; the new launch surface then displays the first false failure (typically “git not found”) on every startup. Use platform-aware executable discovery such as where.exe on Windows before exposing these checks on the default launch path.
Useful? React with 👍 / 👎.
Phase 3 of #557 (keyboard slice): ↑/↓ highlights a recent session on the launch surface and Enter starts the same resume path as the session picker. Same-session selection is a no-op; typing still dismisses the surface. Mouse hit-testing and shimmer remain open.
e1ca140 to
7ad66be
Compare
1 participant
Summary
resume.beginpath as the session picker.feat/launch-startup-surface). Mouse hit-testing and shimmer /reduced_motionremain open.Test plan
cargo test -p agent-code --bin agent launchcargo clippy -p agent-code --all-targets -- -D warningscargo fmt --allDepends on #579.