Closes #30 - Loosened tolerance on unit test EXPECT_NEAR checks#31
Merged
josephduchesne merged 2 commits intoavidbots:masterfrom Oct 15, 2017
Merged
Closes #30 - Loosened tolerance on unit test EXPECT_NEAR checks#31josephduchesne merged 2 commits intoavidbots:masterfrom
josephduchesne merged 2 commits intoavidbots:masterfrom
Conversation
josephduchesne
approved these changes
Oct 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran the test a bunch of times on my computer and never saw a difference greater than the original tolerance of 1e-4, but apparently it is possible. Loosened them to 1cm, which should still be tight enough to catch real problems that aren't just numerical computation error accumulation.