Report the version from build info when ldflags are absent - #2
Merged
Conversation
Only the release workflow passes -ldflags, so a binary from `go install github.com/aviorstudio/gdam@v0.0.6` reported "dev / none / unknown". The version was already in the module metadata Go stamps into every binary; nothing read it. buildInfoVersion fills in version, commit, and date from debug.ReadBuildInfo when they are still at their defaults, so released binaries are unchanged and source-built ones stop lying. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go install github.com/aviorstudio/gdam@v0.0.6reporteddev / none / unknown— only the release workflow passes-ldflags. The version was already in the module metadata Go stamps into every binary; nothing read it.buildInfoVersion()fills in version, commit and date fromdebug.ReadBuildInfo()only when they're still at their defaults, so ldflags always win.Verified both paths:
gdam 9.9.9 / commit: abc123(unchanged)go build→gdam v0.0.6-0.20260730194825-df21bba81463 / commit: df21bba...(wasdev / none / unknown)🤖 Generated with Claude Code