feat: avoid unnecessary stat on every save - #101
Closed
avoidwork wants to merge 0 commit into
Closed
Conversation
avoidwork
force-pushed
the
feat/avoid-unnecessary-mkdir
branch
from
June 4, 2026 22:14
b347e06 to
3ae3bc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
saveSession()was callingstat()+mkdir()on every save call. Since every message triggers a save, this means redundant filesystem checks and directory creation fire N times during a session.This changes
saveSession()to a purewriteFile— the directory is ensured once at init viaensureSessionsDir(). If the directory disappears after init, saves fail (crash) instead of silently creating it.This is an optimization over the existing behavior from #99 — the directory existence guarantee was already in the design, but mkdir was still happening on every save.
Type of Change
Testing
Full test suite: 955/955 tests pass. New tests added:
Coverage
Checklist
npm run lintpasses